Move and refactor integration-cli/registry to internal/test#36839
Merged
thaJeztah merged 1 commit intoApr 13, 2018
Conversation
cpuguy83
approved these changes
Apr 12, 2018
Member
There was a problem hiding this comment.
Nit, WaitReady seems more appropriate here.
Member
|
vdemeester
force-pushed
the
integration-registry-refactoring
branch
from
5c5329d to
29a6192
Compare
- Move the code from `integration-cli` to `internal/test`. - Use `testingT` and `assert` when creating the registry. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
integration-registry-refactoring
branch
from
29a6192 to
66de2e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #36839 +/- ##
=========================================
Coverage ? 34.98%
=========================================
Files ? 614
Lines ? 45673
Branches ? 0
=========================================
Hits ? 15978
Misses ? 27600
Partials ? 2095 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration-clitointernal/test.testingTandassertwhen creating the registry.🦁
Signed-off-by: Vincent Demeester vincent@sbr.pm