Skip to content

[test/integration] Small daemon refactoring and add swarm init/join helpers#36854

Merged
anusha-ragunathan merged 1 commit into
moby:masterfrom
vdemeester:integration-swarm-more-in-internal
Apr 16, 2018
Merged

[test/integration] Small daemon refactoring and add swarm init/join helpers#36854
anusha-ragunathan merged 1 commit into
moby:masterfrom
vdemeester:integration-swarm-more-in-internal

Conversation

@vdemeester
Copy link
Copy Markdown
Member

🦁

Signed-off-by: Vincent Demeester vincent@sbr.pm

@vdemeester vdemeester changed the title Small daemon refactoring and add swarm init/join helpers [test/integration] Small daemon refactoring and add swarm init/join helpers Apr 13, 2018
@vdemeester vdemeester force-pushed the integration-swarm-more-in-internal branch from a4b46fe to 2ae57ef Compare April 13, 2018 12:13
@vdemeester
Copy link
Copy Markdown
Member Author

vdemeester commented Apr 13, 2018

hum I broke something 🤔 (should be fixed now)

@vdemeester vdemeester force-pushed the integration-swarm-more-in-internal branch from 2ae57ef to bf93f08 Compare April 13, 2018 15:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@ea579a6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36854   +/-   ##
=========================================
  Coverage          ?   34.97%           
=========================================
  Files             ?      614           
  Lines             ?    45698           
  Branches          ?        0           
=========================================
  Hits              ?    15984           
  Misses            ?    27620           
  Partials          ?     2094

@thaJeztah
Copy link
Copy Markdown
Member

Janky is failing on a flaky test; https://jenkins.dockerproject.org/job/Docker-PRs/48971/console, which is tracked through #32673

16:29:12 ----------------------------------------------------------------------
16:29:12 FAIL: docker_api_swarm_test.go:297: DockerSwarmSuite.TestAPISwarmLeaderElection
16:29:12 
16:29:12 [d478405b8f18b] waiting for daemon to start
16:29:12 [d478405b8f18b] daemon started
16:29:12 
16:29:12 [d5b688c6ab843] waiting for daemon to start
16:29:12 [d5b688c6ab843] daemon started
16:29:12 
16:29:12 [deb10f5554730] waiting for daemon to start
16:29:12 [deb10f5554730] daemon started
16:29:12 
16:29:12 [d478405b8f18b] exiting daemon
16:29:12 assertion failed: error is not nil: Error response from daemon: rpc error: code = DeadlineExceeded desc = context deadline exceeded
16:29:12 [d5b688c6ab843] exiting daemon
16:29:12 [deb10f5554730] exiting daemon
16:29:36 

Windows failure (https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/20409/console) is also flaky #33301

16:10:27 ----------------------------------------------------------------------
16:10:27 FAIL: docker_api_logs_test.go:23: DockerSuite.TestLogsAPIWithStdout
16:10:27 
16:10:27 docker_api_logs_test.go:55:
16:10:27     c.Fatal("timeout waiting for logs to exit")
16:10:27 ... Error: timeout waiting for logs to exit
16:10:27 

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anusha-ragunathan
Copy link
Copy Markdown
Contributor

LGTM

@anusha-ragunathan anusha-ragunathan merged commit c65d365 into moby:master Apr 16, 2018
@vdemeester vdemeester deleted the integration-swarm-more-in-internal branch April 16, 2018 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants