Add FIPS types to the moby types#36893
Closed
cyli wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Ying Li <ying.li@docker.com>
…des be in FIPS mode. Signed-off-by: Ying Li <ying.li@docker.com>
Contributor
Author
thaJeztah
added
area/api
Member
|
Given that this is an API change, we'll have to:
|
Contributor
|
Not sure we need this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a FIPS boolean to the node description and cluster info for a swarm.
The node description boolean was added to swarmkit in moby/swarmkit#2587, and was pulled into moby/moby with #36880.
The cluster boolean is added here: moby/swarmkit#2594, and has not yet been merged into swarmkit.
But adding the types now lets us modify the CLI concurrently to display said information.