Do not return "<unknown>" in /info response #37472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Jul 16, 2018
|
|
||
| [Docker Engine API v1.39](https://docs.docker.com/engine/api/v1.39/) documentation | ||
|
|
||
| * `GET /info` now returns an empty string, instead of `<unknown>` for `KernelVersion` |
Member
Author
There was a problem hiding this comment.
Looks like we don't explicitly document the <unknown> value, so perhaps this is all not needed
Codecov Report
@@ Coverage Diff @@
## master #37472 +/- ##
=========================================
Coverage ? 34.95%
=========================================
Files ? 610
Lines ? 44883
Branches ? 0
=========================================
Hits ? 15689
Misses ? 27074
Partials ? 2120 |
Member
Author
|
ping @tiborvass PTAL |
Member
Author
|
I'll do a self-five here, as it has two LGTM's an CI is green (ignoring codecov) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<unknown>string is presentation, and should be created by the CLI (if desirable); follow-up to #37451