Skip to content

integration-cli: remove deprecated daemonHost() utility#38603

Merged
yongtang merged 1 commit intomoby:masterfrom
thaJeztah:remove_deprecated_daemonhost
Jan 23, 2019
Merged

integration-cli: remove deprecated daemonHost() utility#38603
yongtang merged 1 commit intomoby:masterfrom
thaJeztah:remove_deprecated_daemonhost

Conversation

@thaJeztah
Copy link
Member

It was only used in a few places still, so removed those places and removed the function.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @vdemeester @yongtang

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5ec3138). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #38603   +/-   ##
=========================================
  Coverage          ?    36.6%           
=========================================
  Files             ?      608           
  Lines             ?    45224           
  Branches          ?        0           
=========================================
  Hits              ?    16556           
  Misses            ?    26382           
  Partials          ?     2286

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants