integration-cli: getContainerCount() fix trimming prefix#39819
Merged
thaJeztah merged 1 commit intomoby:masterfrom Sep 5, 2019
Merged
integration-cli: getContainerCount() fix trimming prefix#39819thaJeztah merged 1 commit intomoby:masterfrom
thaJeztah merged 1 commit intomoby:masterfrom
Conversation
tonistiigi
approved these changes
Aug 30, 2019
caught by staticcheck: ``` integration-cli/docker_utils_test.go:66:29: SA1024: cutset contains duplicate characters (staticcheck) ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2986225 to
02c9b06
Compare
Member
Author
|
rebased to cleanup old CI results @kolyshkin @AkihiroSuda PTAL |
AkihiroSuda
approved these changes
Sep 3, 2019
Member
Author
|
Windows RS1 failure: https://ci.docker.com/public/job/moby/job/PR-39819/2/execution/node/190/log/ Haven't seen that one before; looks like possible slowness on those machines? Windows RS5 failure is a known flaky: https://ci.docker.com/public/job/moby/job/PR-39819/2/execution/node/177/log/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitting this from #39668
caught by staticcheck: