hack/ci/windows.ps1: add support for DOCKER_STORAGE_OPTS#39877
Merged
cpuguy83 merged 1 commit intomoby:masterfrom Sep 12, 2019
Merged
hack/ci/windows.ps1: add support for DOCKER_STORAGE_OPTS#39877cpuguy83 merged 1 commit intomoby:masterfrom
cpuguy83 merged 1 commit intomoby:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
@StefanScherer @vikramhh ptal |
|
@thaJeztah - the change looks good to me. But why scope it to storage options alone? By having the caller provide a fully crafted "additional" options as a string[say Caller would also be responsible for ensuring that nothing in |
Member
Author
|
I added this change for testing hyper-v containers; limiting just to storage driver options, so that we have the same variable name as elsewhere; Line 52 in 9b25c0f |
tiborvass
approved these changes
Sep 12, 2019
cpuguy83
approved these changes
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(taken from #39846)
Modelled after the way it's handled in the Linux scripts