hack/make/.go-autogen: fix LDFLAGS to accept values with spaces #40393
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
tianon
approved these changes
Jan 18, 2020
Member
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
If Go's -ldflags accepts inline ' (single quotes), this could be made a little easier to read (ditching the \), but that's a pretty minor thing.
LGTM
arkodg
approved these changes
Jan 18, 2020
Member
Author
|
I could give that another try perhaps. But I got crazy with all the quoting to get it working 😂 |
Member
|
Yeah, IMO not a blocker by any means for merging this, just something we
could consider in the future if someone is bored and has a minute to test
it out. 😅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to docker/docker-ce-packaging#415 (comment)
relates to docker/docker-ce-packaging#417
relates to #40180