refactor(libcontainer): rename to CapabilitiesMask#4719
Merged
creack merged 2 commits intomoby:masterfrom Mar 17, 2014
Merged
Conversation
Contributor
|
@philips can you update the readme and container.json files in libcontainer? |
Contributor
Author
|
@crosbymichael Sure. I guess that means you like the new name? |
added 2 commits
March 17, 2014 11:07
The Capabilities field on libcontainer is actually used as a mask. Rename the field so that this is more clear. Docker-DCO-1.1-Signed-off-by: Brandon Philips <brandon.philips@coreos.com> (github: philips)
Someone probably got really used to typing er on the end of contain :) Docker-DCO-1.1-Signed-off-by: Brandon Philips <brandon.philips@coreos.com> (github: philips)
Contributor
|
@philips yes, it works for me and it will not cause any issues doing the rename because these files on disk only last for the run of a container. Feel free to submit more PRs for libcontainer ;) |
Contributor
Author
|
@crosbymichael Fixed the README and container.json. Also, fixed a funny grammar thing in ad7e7d6. I know the feeling... I don't know how many times I have tried to |
Contributor
|
LGTM :) |
creack
added a commit
that referenced
this pull request
Mar 17, 2014
refactor(libcontainer): rename to CapabilitiesMask
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Capabilities field on libcontainer is actually used as a mask. Rename the
field so that this is more clear.
NOTE: This is completely untested, wanted to make sure @creack agreed
with me first.
Docker-DCO-1.1-Signed-off-by: Brandon Philips brandon.philips@coreos.com (github: philips)