Skip to content

Internode healthcheck shouldn't change service package #1112

@stevvooe

Description

@stevvooe

For the node health checking to be compatible with GRPC health checking, the package name cannot change. It must be package grpc.health.v1.

https://github.com/docker/swarmkit/pull/957/files#diff-1131a495e9663ab73eadbeb399282a92R12

The big use case here is GRPC load balancing, but I am not sure yet how this will integrate, so registering two health check services on separate package paths may be okay.

cc @abronan @aaronlehmann

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions