Add constrained scheduler benchmarks#1028
Merged
aaronlehmann merged 1 commit intoJun 29, 2016
Merged
Conversation
Current coverage is 53.91%@@ master #1028 diff @@
==========================================
Files 75 75
Lines 11671 11642 -29
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 6266 6277 +11
+ Misses 4501 4474 -27
+ Partials 904 891 -13
|
| } | ||
|
|
||
| func benchScheduler(b *testing.B, nodes, tasks int, worstCase bool) { | ||
| func benchScheduler(b *testing.B, nodes, tasks int, constraints, worstCase bool) { |
Contributor
There was a problem hiding this comment.
Might be better change constraints to networkConstraints. It's different from --constraint in service.
This benchmarks scheduling with constraints, where only 1/3 of the nodes are eligible to run the tasks. Under the current implementation, this converges towards the worst-case linear behavior, because the nodes that meet the constraints end up at the end of the heap, and findMin has to scan much of the heap to find them. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
aaronlehmann
force-pushed
the
add-constrained-scheduling-benchmarks
branch
from
2482a83 to
822cdfe
Compare
Collaborator
Author
|
Updated, PTAL. |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This benchmarks scheduling with constraints, where only 1/3 of the nodes
are eligible to run the tasks.
Under the current implementation, this converges towards the worst-case
linear behavior, because the nodes that meet the constraints end up at
the end of the heap, and findMin has to scan much of the heap to find
them.