Fix integration test data race and slowness#1920
Merged
Merged
Conversation
cyli
force-pushed
the
fix-integration-test
branch
from
cbb4049 to
95442d5
Compare
cyli
changed the title
aaronlehmann
reviewed
Feb 3, 2017
| log.WithFields(logrus.Fields{ | ||
| "time": time.Now().Add(retry), | ||
| }).Debugf("next certificate renewal scheduled") | ||
| }).Debugf("next certificate renewal scheduled for %v", retry) |
Collaborator
There was a problem hiding this comment.
This should probably log the time when the renewal is scheduled, or phrase it as "for %v from now"
…e integration test. Also, add the following optimizations for the integration tests: - make the renew TLS certificate loop's exponential backoff configurable, so it can be set for testing - if a node exits before it's ready, bail `integration.cluster.StartNode` early so we don't have to wait for the timeout Signed-off-by: cyli <ying.li@docker.com>
cyli
force-pushed
the
fix-integration-test
branch
from
95442d5 to
9dbe262
Compare
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1919 inadvertently left a
logrus.Debugsetting in the integration test, which was causing a data race.Also, add the following optimizations for the integration test added in #1919:
integration.cluster.StartNodeearly so we don't have towait for the timeout
Signed-off-by: cyli ying.li@docker.com