[ca] Separate CreateRootCA from saving root CA#2050
Merged
Conversation
cyli
changed the title
CreateRootCA from saving root CACreateRootCA from saving root CA
…d also call SaveRootCA. Signed-off-by: cyli <ying.li@docker.com>
cyli
force-pushed
the
split-create-root-ca-and-save
branch
from
6be19c8 to
e310156
Compare
Codecov Report
@@ Coverage Diff @@
## master #2050 +/- ##
==========================================
- Coverage 54.05% 54.01% -0.05%
==========================================
Files 111 111
Lines 19332 19332
==========================================
- Hits 10450 10442 -8
+ Misses 7632 7630 -2
- Partials 1250 1260 +10Continue to review full report at Codecov.
|
3 tasks
diogomonica
approved these changes
Mar 23, 2017
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor refactor that would be useful when autogenerating Root CAs as part of root rotation (if the user wants swarm to just generate a key and cert for them)