[ca] Minor cleanups#2067
Merged
Merged
Conversation
…mediate must have the same subject and public key as the signing cert), and cleaning up an extra useless variable. Signed-off-by: cyli <ying.li@docker.com>
Collaborator
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #2067 +/- ##
========================================
+ Coverage 54.2% 54.3% +0.1%
========================================
Files 111 111
Lines 19352 19351 -1
========================================
+ Hits 10489 10508 +19
+ Misses 7595 7582 -13
+ Partials 1268 1261 -7Continue to review full report at Codecov.
|
Contributor
Author
|
Just going to merge this one, because it's super tiny. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While re-organizing #2052, pulled out some minor changes that don't really fit. This just adds an additional test case I had forgotten for validating intermediates, and cleans up an extra variable declaration.