Skip TestUpdaterRollbackAndPauseNoMonitor#2245
Merged
Merged
Conversation
This test triggers a race condition in the way the updater and restart supervisor interact. The problem is normally masked by a second reconciliation pass triggered as a side effect of the update completing, but this test case does not wait long enough for the update to be declared complete. Since the test does not pass reliably, it should be skipped until the underlying issue is fixed. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
- Coverage 60.41% 60.35% -0.07%
==========================================
Files 124 124
Lines 20248 20248
==========================================
- Hits 12233 12220 -13
- Misses 6642 6653 +11
- Partials 1373 1375 +2 |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test triggers a race condition in the way the updater and restart supervisor interact.
The problem is normally masked by a second reconciliation pass triggered as a side effect of the update completing, but this test case does not wait long enough for the update to be declared complete.
Since the test does not pass reliably, it should be skipped until the underlying issue (#2242) is fixed.
Fixes #2137