[ca] In the CA server, ensure we always have a cluster ID#2340
Merged
Conversation
changes of the only cluster we care about. Signed-off-by: Ying Li <ying.li@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2340 +/- ##
==========================================
- Coverage 60.38% 60.35% -0.04%
==========================================
Files 128 128
Lines 26056 26052 -4
==========================================
- Hits 15735 15724 -11
- Misses 8934 8940 +6
- Partials 1387 1388 +1 |
Collaborator
|
LGTM |
Contributor
Author
|
Thanks @aaronlehmann! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, and just watch for changes of the only cluster we care about. This fixes an occasional data race caused by #2336 where the cluster is accessed outside of a lock. Alternative is to lock before accessing the cluster ID, but this seems simpler.
Signed-off-by: Ying Li ying.li@docker.com