Update task status during a network allocation failure#2358
Conversation
|
Please sign your commits following these rules: $ git clone -b "network_alloc_errors" git@github.com:wsong/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
wsong
force-pushed
the
network_alloc_errors
branch
from
339c497 to
f3b1b8b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2358 +/- ##
==========================================
- Coverage 60.2% 60.04% -0.16%
==========================================
Files 128 128
Lines 26191 26200 +9
==========================================
- Hits 15768 15733 -35
- Misses 9032 9073 +41
- Partials 1391 1394 +3 |
aaronlehmann
left a comment
aaronlehmann
left a comment
There was a problem hiding this comment.
This change is related to #2287, and should probably be paired with that one.
| "time" | ||
|
|
||
| "github.com/docker/go-events" | ||
| events "github.com/docker/go-events" |
There was a problem hiding this comment.
This change shouldn't be necessary.
| quiet = true | ||
| } | ||
| allocatedTasks := make([]*api.Task, 0, len(toAllocate)) | ||
| errorTasks := make([]*api.Task, 0, len(toAllocate)) |
There was a problem hiding this comment.
Where do tasks get added to this slice?
There was a problem hiding this comment.
Whoops, forgot to update this code block. Fixed.
Signed-off-by: Wayne Song <wsong@docker.com>
wsong
force-pushed
the
network_alloc_errors
branch
from
f3b1b8b to
df08abd
Compare
| quiet = true | ||
| } | ||
| allocatedTasks := make([]*api.Task, 0, len(toAllocate)) | ||
| errorTasks := make([]*api.Task, 0, len(toAllocate)) |
There was a problem hiding this comment.
Whoops, forgot to update this code block. Fixed.
|
I think we should move it forward. |
|
This was superseded by #2287 |
3 participants
No description provided.