[17.10] Don't filter nodes if logdriver==none#2402
Merged
Conversation
The "none" driver is a special keyword to disable logging, so don't filter nodes if the "none" driver is not listed on the nodes, since it's not really a driver and doesn't exist. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 9608c63) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Author
nishanttotla
approved these changes
Oct 11, 2017
Contributor
|
Let's merge once the CI is green. Tagging @thaJeztah @cpuguy83 for reference. |
Codecov Report
@@ Coverage Diff @@
## bump_v17.10 #2402 +/- ##
===============================================
- Coverage 60.85% 60.51% -0.34%
===============================================
Files 128 128
Lines 26303 26303
===============================================
- Hits 16007 15918 -89
- Misses 8897 8992 +95
+ Partials 1399 1393 -6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport:
With cherry-pick of 9608c63:
Went in clean.