[v17.03] Cherry-pick Delete node attachments when node is removed#2417
Merged
nishanttotla merged 1 commit intoOct 23, 2017
Merged
Conversation
nishanttotla
approved these changes
Oct 23, 2017
Contributor
nishanttotla
left a comment
nishanttotla
left a comment
There was a problem hiding this comment.
LGTM
(need to also vendor #2377 to fix CI failure. Can merge once that is done)
anshulpundir
approved these changes
Oct 23, 2017
Collaborator
Author
|
depends on #2418 to pass CI. |
When a node is removed, delete all of its attachment tasks, so that any networks being used by those tasks can be successfully removed. Provides a workaround to the state where a node with attachments is somehow removed from the cluster while attached to a network, preventing the network from being removed. Does not fix many other related bugs. Includes a unit test for the function that removes node attachment tasks. Cherry picks moby#2409 to 17.03. Cherry-pick applies cleanly. (cherry picked from commit 0c7b2fc) Signed-off-by: Drew Erny <drew.erny@docker.com>
dperny
force-pushed
the
bump_v17.03-cherry-pick-2409
branch
from
704b1c4 to
3395393
Compare
Codecov Report
@@ Coverage Diff @@
## bump_v17.03 #2417 +/- ##
===============================================
+ Coverage 55.78% 55.89% +0.11%
===============================================
Files 102 102
Lines 21532 21554 +22
===============================================
+ Hits 12011 12047 +36
+ Misses 8368 8362 -6
+ Partials 1153 1145 -8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a node is removed, delete all of its attachment tasks, so that any
networks being used by those tasks can be successfully removed.
Provides a workaround to the state where a node with attachments is
somehow removed from the cluster while attached to a network, preventing
the network from being removed. Does not fix many other related bugs.
Includes a unit test for the function that removes node attachment
tasks.
Cherry picks #2409 to 17.03. Cherry-pick applies cleanly.
(cherry picked from commit 0c7b2fc)
Signed-off-by: Drew Erny drew.erny@docker.com