Skip to content

[17.11] normalize "aarch64" architectures to "arm64"#2427

Merged
nishanttotla merged 1 commit into
moby:bump_v17.11from
nishanttotla:normalize-aarch64-to-arm64-17.11
Nov 6, 2017
Merged

[17.11] normalize "aarch64" architectures to "arm64"#2427
nishanttotla merged 1 commit into
moby:bump_v17.11from
nishanttotla:normalize-aarch64-to-arm64-17.11

Conversation

@nishanttotla
Copy link
Copy Markdown
Contributor

Cherry-pick #2411.

git cherry-pick -s -x 9d702763118b132cbe9005a80625ba2160089c3d

Cherry-pick was clean.

@nishanttotla
Copy link
Copy Markdown
Contributor Author

nishanttotla commented Nov 3, 2017

Ping @anshulpundir @thaJeztah @andrewhsu

@nishanttotla nishanttotla changed the title normalize "aarch64" architectures to "arm64" [17.11] normalize "aarch64" architectures to "arm64" Nov 3, 2017
Copy link
Copy Markdown
Contributor

@anshulpundir anshulpundir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change needed in 17.11 ?

@nishanttotla
Copy link
Copy Markdown
Contributor Author

@anshulpundir since the SwarmKit vendoring wasn't updated in moby/moby in a while, several commits are missing from the release, so we're having to backport.

@anshulpundir
Copy link
Copy Markdown
Contributor

anshulpundir commented Nov 3, 2017

Makes sense. So the goal is to have 17.11 based off of swarmkit master ? @nishanttotla

@nishanttotla
Copy link
Copy Markdown
Contributor Author

nishanttotla commented Nov 3, 2017

@anshulpundir the 17.11 release was cut when the vendored SwarmKit commit was 872861d2ae46958af7ead1d5fffb092c73afbaf0. This is several commits behind master. Instead of just bringing it up to date with master, we're trying to make sure that

  • there are no regressions
  • all useful bugfixes/features that were merged in SwarmKit in the last few weeks are actually included

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 3, 2017

Codecov Report

Merging #2427 into bump_v17.11 will decrease coverage by 0.68%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##           bump_v17.11    #2427      +/-   ##
===============================================
- Coverage        61.25%   60.57%   -0.69%     
===============================================
  Files              128      128              
  Lines            26366    26372       +6     
===============================================
- Hits             16151    15974     -177     
- Misses            8798     8996     +198     
+ Partials          1417     1402      -15

Signed-off-by: Aaron Welch <welch@packet.net>
(cherry picked from commit 9d70276)
Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
@nishanttotla nishanttotla force-pushed the normalize-aarch64-to-arm64-17.11 branch from 763e80f to d5033c5 Compare November 3, 2017 22:26
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants