[17.11] Delete node attachments when node is removed#2428
Closed
nishanttotla wants to merge 1 commit into
Closed
Conversation
When a node is removed, delete all of its attachment tasks, so that any networks being used by those tasks can be successfully removed. Provides a workaround to the state where a node with attachments is somehow removed from the cluster while attached to a network, preventing the network from being removed. Does not fix many other related bugs. Includes a unit test for the function that removes node attachment tasks. Signed-off-by: Drew Erny <drew.erny@docker.com> (cherry picked from commit 0c7b2fc) Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
Contributor
Author
|
Ping @dperny @thaJeztah @andrewhsu |
anshulpundir
approved these changes
Nov 3, 2017
Codecov Report
@@ Coverage Diff @@
## bump_v17.11 #2428 +/- ##
==============================================
- Coverage 60.96% 60.5% -0.47%
==============================================
Files 128 128
Lines 26303 26325 +22
==============================================
- Hits 16035 15927 -108
- Misses 8877 8988 +111
- Partials 1391 1410 +19 |
Contributor
Author
|
Closing PR because 17.11 branch is now cut off at 312be59, which includes this commit. |
nishanttotla
deleted the
delete-node-attachments-when-node-is-removed-17.11
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2409
git cherry-pick -s -x 0c7b2fc23685c6ab80f2d1c82ce63d66dd3f25baCherry-pick was clean.