[17.11] Avoid running plugin filter when Log Driver does not have a Name#2439
Closed
nishanttotla wants to merge 1 commit into
Closed
[17.11] Avoid running plugin filter when Log Driver does not have a Name#2439nishanttotla wants to merge 1 commit into
nishanttotla wants to merge 1 commit into
Conversation
Signed-off-by: Nishant Totla <nishanttotla@gmail.com> (cherry picked from commit 05c8675) Signed-off-by: Nishant Totla <nishanttotla@gmail.com>
Codecov Report
@@ Coverage Diff @@
## bump_v17.11 #2439 +/- ##
==============================================
- Coverage 66.11% 60.7% -5.42%
==============================================
Files 80 128 +48
Lines 14653 26372 +11719
==============================================
+ Hits 9688 16008 +6320
- Misses 4173 8956 +4783
- Partials 792 1408 +616 |
|
LGTM |
anshulpundir
approved these changes
Nov 11, 2017
Contributor
Author
|
@thaJeztah @andrewhsu is this ok to merge? |
Member
|
oh, actually; this is for 17.11, which is EOL, so looks like we no longer need this? |
Member
|
Looks like it's in 17.12; https://github.com/docker/docker-ce/blob/17.12/components/engine/vendor/github.com/docker/swarmkit/manager/scheduler/filter.go#L172-L181 so we can close this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2438.
git cherry-pick -s -x 05c8675eeeece04daffec34c5f99769b560d2d0dCherry-pick was clean.