[17.09] Delete node attachments when node is removed#2456
Merged
anshulpundir merged 1 commit intoNov 20, 2017
Merged
Conversation
When a node is removed, delete all of its attachment tasks, so that any networks being used by those tasks can be successfully removed. Provides a workaround to the state where a node with attachments is somehow removed from the cluster while attached to a network, preventing the network from being removed. Does not fix many other related bugs. Includes a unit test for the function that removes node attachment tasks. Signed-off-by: Drew Erny <drew.erny@docker.com> (cherry picked from commit 0c7b2fc) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
17.09-backport-workaround-attachments
branch
from
41eb117 to
f51bdb6
Compare
Codecov Report
@@ Coverage Diff @@
## bump_v17.09 #2456 +/- ##
===============================================
+ Coverage 60.2% 60.39% +0.19%
===============================================
Files 128 128
Lines 26170 26192 +22
===============================================
+ Hits 15755 15819 +64
+ Misses 9033 8984 -49
- Partials 1382 1389 +7 |
nishanttotla
approved these changes
Nov 20, 2017
Contributor
nishanttotla
left a comment
nishanttotla
left a comment
There was a problem hiding this comment.
@thaJeztah just confirming that the cherry-pick was clean?
Member
Author
|
Yes, no conflicts 👍 |
anshulpundir
approved these changes
Nov 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #2409 for 17.09
When a node is removed, delete all of its attachment tasks, so that any
networks being used by those tasks can be successfully removed.
Provides a workaround to the state where a node with attachments is
somehow removed from the cluster while attached to a network, preventing
the network from being removed. Does not fix many other related bugs.
Includes a unit test for the function that removes node attachment
tasks.
(cherry picked from commit 0c7b2fc)
ping @dperny @anshulpundir PTAL