[Backport 17.12] Added required call to allocate VIPs when endpoints are restored#2474
Merged
Conversation
On leader change or leader reboot the restore logic in the allocator was allocating overlapping IP address for VIPs and Endpoints in the ingress network. The fix added as part of this commit ensures that during restore we allocate the existing VIP and endpoint. Signed-off-by: Balraj Singh <balrajsingh@ieee.org>
Signed-off-by: Balraj Singh <balrajsingh@ieee.org>
Codecov Report
@@ Coverage Diff @@
## bump_v17.12 #2474 +/- ##
===============================================
- Coverage 61.8% 61.72% -0.09%
===============================================
Files 128 128
Lines 21107 21109 +2
===============================================
- Hits 13045 13029 -16
- Misses 6664 6668 +4
- Partials 1398 1412 +14 |
Contributor
Author
|
@dperny can you PTAL ? |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a new PR to get things moving. The original back port PR #2472