Orchestrator/taskreaper: Add unit-test for service remove with dead t…#2476
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2476 +/- ##
==========================================
+ Coverage 61.61% 62.51% +0.89%
==========================================
Files 129 129
Lines 21243 21243
==========================================
+ Hits 13089 13279 +190
+ Misses 6739 6537 -202
- Partials 1415 1427 +12 |
Collaborator
|
This test is failing. |
Contributor
Author
|
Passing locally, need to look why. |
Contributor
nishanttotla
left a comment
nishanttotla
left a comment
There was a problem hiding this comment.
Test looks fine, but I'll run it locally as well.
anshulpundir
commented
Jan 2, 2018
Contributor
Author
anshulpundir
left a comment
anshulpundir
left a comment
There was a problem hiding this comment.
I think its just taking longer to converge @nishanttotla
…asks. Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Collaborator
|
LGTM |
nishanttotla
approved these changes
Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit-test for testing service remove with dead tasks.
Signed-off-by: Anshul Pundir anshul.pundir@docker.com