Redact registry auth token from swarm-rafttool#2501
Merged
Conversation
anshulpundir
approved these changes
Feb 5, 2018
Contributor
|
This is not blocking, but we should probably add a unit-test at some point. |
nishanttotla
reviewed
Feb 7, 2018
| if task != nil { | ||
| if container := task.Spec.GetContainer(); container != nil { | ||
| container.Env = []string{"ENVVARS REDACTED"} | ||
| container.PullOptions.RegistryAuth = "REDACTED" |
Contributor
There was a problem hiding this comment.
@dperny don't we need to check for container.PullOptions to be nil?
When I added the --redact flag for swarm-rafttool, I forgot to include the registry auth token as sensitive data to be redacted, so it was present in redacted raft dumps. This replaces it with a redaction. Signed-off-by: Drew Erny <drew.erny@docker.com>
dperny
force-pushed
the
redact-registry-auth
branch
from
0ed9c00 to
8fbde78
Compare
Codecov Report
@@ Coverage Diff @@
## master #2501 +/- ##
==========================================
+ Coverage 61.33% 61.54% +0.21%
==========================================
Files 133 129 -4
Lines 21714 21331 -383
==========================================
- Hits 13318 13128 -190
+ Misses 6965 6794 -171
+ Partials 1431 1409 -22 |
nishanttotla
approved these changes
Feb 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I added the --redact flag for swarm-rafttool, I forgot to include the registry auth token as sensitive data to be redacted, so it was present in redacted raft dumps. This replaces it with a redaction.