Revert "[manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs." #2521
Merged
Conversation
…ing rpcs." This reverts commit 0b2778a. Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Collaborator
|
LGTM, can we wait on CI to finish? |
Contributor
Author
|
Yep, lets merge on green CI @dperny |
Codecov Report
@@ Coverage Diff @@
## bump_v17.06 #2521 +/- ##
===============================================
+ Coverage 60.83% 60.99% +0.16%
===============================================
Files 121 121
Lines 20139 20129 -10
===============================================
+ Hits 12251 12278 +27
+ Misses 6545 6498 -47
- Partials 1343 1353 +10 |
fcrisciani
approved these changes
Feb 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of the revert from master. Cherry pick was pretty much clean.
git cherry-pick f39f943