[backport, 17.06] RoleManager will remove deleted nodes from the cluster membership#2607
Merged
Merged
Conversation
anshulpundir
approved these changes
Apr 17, 2018
cyli
force-pushed
the
backport-rolemanager-17.06
branch
from
48092fb to
a0235de
Compare
Codecov Report
@@ Coverage Diff @@
## bump_v17.06 #2607 +/- ##
===============================================
- Coverage 61.84% 61.24% -0.6%
===============================================
Files 42 121 +79
Lines 5692 20196 +14504
===============================================
+ Hits 3520 12369 +8849
- Misses 1835 6474 +4639
- Partials 337 1353 +1016 |
Contributor
Author
|
As a note, I think the test failures are due to the flakiness that was fixed by #2575. Not sure it's worth backporting those tests though, so I'll just rebuild. |
Contributor
Author
|
Closing this as I think we aren't going to be porting anything back to 17.06 anymore. |
cyli
force-pushed
the
backport-rolemanager-17.06
branch
from
a0235de to
9e8473f
Compare
cyli
force-pushed
the
backport-rolemanager-17.06
branch
from
9e8473f to
589e16e
Compare
Contributor
Author
|
This is hitting every flakey test failure :( |
both on startup and while a node is demoted while it's running. Also add a failing test, where the roleManager should remove deleted nodes from the cluster membership on startup. These tests involve injecting a fake clock source into roleManager. Signed-off-by: cyli <cyli@twistedmatrix.com> (cherry picked from commit 1d68e61) Signed-off-by: Ying Li <ying.li@docker.com>
…nger in the raft store. Signed-off-by: cyli <ying.li@docker.com> (cherry picked from commit 5322ff5) Signed-off-by: Ying Li <ying.li@docker.com>
… node that is a manager can be removed if it hasn't joined the raft cluster yet. However, perhaps the raft conf change happens right after the check. Signed-off-by: Ying Li <ying.li@docker.com> (cherry picked from commit 36954b5) Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
backport-rolemanager-17.06
branch
from
589e16e to
6443149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #2551 to the 17.06 branch.