[backport, 18.03] RoleManager will remove deleted nodes from the cluster membership#2608
Merged
Merged
Conversation
anshulpundir
approved these changes
Apr 18, 2018
both on startup and while a node is demoted while it's running. Also add a failing test, where the roleManager should remove deleted nodes from the cluster membership on startup. These tests involve injecting a fake clock source into roleManager. Signed-off-by: cyli <cyli@twistedmatrix.com> (cherry picked from commit 1d68e61) Signed-off-by: Ying Li <ying.li@docker.com>
…nger in the raft store. Signed-off-by: cyli <ying.li@docker.com> (cherry picked from commit 5322ff5) Signed-off-by: Ying Li <ying.li@docker.com>
… node that is a manager can be removed if it hasn't joined the raft cluster yet. However, perhaps the raft conf change happens right after the check. Signed-off-by: Ying Li <ying.li@docker.com> (cherry picked from commit 36954b5) Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
backport-rolemanager-18.03
branch
from
29127f6 to
fbb747c
Compare
Codecov Report
@@ Coverage Diff @@
## bump_v18.03 #2608 +/- ##
===============================================
+ Coverage 61.46% 62.06% +0.59%
===============================================
Files 133 133
Lines 21746 21770 +24
===============================================
+ Hits 13366 13511 +145
+ Misses 6944 6803 -141
- Partials 1436 1456 +20 |
Contributor
Author
|
Rebased this after @nishanttotla's backport PR #2616 was merged, since that fixes the test flakiness. |
nishanttotla
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #2551 to 18.03.