Don't use wrappers for grpc metadata#2610
Conversation
This switches the current usage of NewContext and FromContext to use the underlying methods in the metadata package. This will be removed in future versions of grpc. Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2610 +/- ##
==========================================
- Coverage 61.74% 61.58% -0.17%
==========================================
Files 134 134
Lines 21763 21763
==========================================
- Hits 13438 13403 -35
- Misses 6869 6914 +45
+ Partials 1456 1446 -10 |
|
@thaJeztah i know. not bumping with this change for that reason |
cyli
left a comment
cyli
left a comment
There was a problem hiding this comment.
LGTM - for other reviewers, this is NewContext (https://github.com/grpc/grpc-go/blob/d2e1b51f33ff8c5e4a15560ff049d200e83726c5/metadata/metadata.go#L111) and FromContext (https://github.com/grpc/grpc-go/blob/d2e1b51f33ff8c5e4a15560ff049d200e83726c5/metadata/metadata.go#L126) from the version of GRPC that we are using.
|
Is there a functional difference between these two that we need to care about? If not, LGTM. |
|
@dperny I believe the one we're using was deprecated and then finally removed. It just calls the new one. |
|
@dperny @cyli correct; see my comment on the other pr: #2452 (comment) |
Updates swarmkit to 33d06bf, to bring in moby/swarmkit#2610 (Don't use wrappers for grpc metadata) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Updates swarmkit to 33d06bf5189881b4d1e371b5571f4d3acf832816, to bring in moby/swarmkit#2610 (Don't use wrappers for grpc metadata) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: b18f7033b2644c0246345bb5747a5436568b1a71 Component: engine
5 participants
This switches the current usage of NewContext and FromContext to use the
underlying methods in the metadata package. The wrappers will be removed in
future versions of grpc.
Signed-off-by: Michael Crosby crosbymichael@gmail.com