WIP Do not merge - just testing something#2640
Closed
cyli wants to merge 9 commits intomoby:masterfrom
Closed
Conversation
|
Please sign your commits following these rules: $ git clone -b "thaJeztah-update-grpc-etc" git@github.com:cyli/swarmkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354264416
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
…r that can surface TLS handshake errors, which GRPC considers transient. Signed-off-by: Ying Li <ying.li@docker.com>
Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
thaJeztah-update-grpc-etc
branch
from
04dff9b to
8ca2bcf
Compare
Codecov Report
@@ Coverage Diff @@
## master #2640 +/- ##
==========================================
+ Coverage 61.96% 67.43% +5.47%
==========================================
Files 134 98 -36
Lines 21823 14566 -7257
==========================================
- Hits 13522 9823 -3699
+ Misses 6856 3732 -3124
+ Partials 1445 1011 -434 |
cyli
force-pushed
the
thaJeztah-update-grpc-etc
branch
from
fb14082 to
df3785f
Compare
…lying a GRPC server closed, so remove that assertion from the tests. Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
thaJeztah-update-grpc-etc
branch
from
df3785f to
ffef158
Compare
…gger to discard in init functions, rather than in TestMain functions. Signed-off-by: Ying Li <ying.li@docker.com>
cyli
force-pushed
the
thaJeztah-update-grpc-etc
branch
from
a0f5907 to
d3c1362
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing fix to #2631