[17.06] Backport manager test fixes#2643
Merged
Merged
Conversation
…ager), it may take a little while for the dispatcher to come up, so poll until it's up. In the second case (TestManagerLockUnlock), we wait for the TLS key bytes to change to test to see whether it has been decrypted after disabling the unlock key. However, it could have changed due to a renewal due to the previous unlock key rotation. So when polling, check that it's decrypted. Signed-off-by: Ying Li <ying.li@docker.com> (cherry picked from commit 6498260)
anshulpundir
approved these changes
May 23, 2018
Codecov Report
@@ Coverage Diff @@
## bump_v17.06 #2643 +/- ##
==============================================
Coverage ? 61.01%
==============================================
Files ? 120
Lines ? 20043
Branches ? 0
==============================================
Hits ? 12230
Misses ? 6469
Partials ? 1344 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #2575 to 17.06 in an attempt to fix CI flakiness.
cc @nishanttotla