Revert "[orchestrator/task reaper] Clean up tasks in dirty list for which the service has been deleted."#2674
Closed
anshulpundir wants to merge 1 commit into
Closed
Revert "[orchestrator/task reaper] Clean up tasks in dirty list for which the service has been deleted."#2674anshulpundir wants to merge 1 commit into
anshulpundir wants to merge 1 commit into
Conversation
|
Please sign your commits following these rules: $ git clone -b "reap_rev" git@github.com:anshulpundir/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
…hich the service has been deleted." This reverts commit 592e8ed. Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2674 +/- ##
==========================================
+ Coverage 62.06% 62.14% +0.07%
==========================================
Files 134 134
Lines 21740 21739 -1
==========================================
+ Hits 13494 13510 +16
+ Misses 6794 6771 -23
- Partials 1452 1458 +6 |
Collaborator
|
why not include this revert commit as part of #2675 ? |
Contributor
Author
|
Revert no longer needed since the approach we're going with in #2675 is essentially an addition on top of this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 592e8ed.
Reverting this now and putting in another fix to address task reaper issues.