[18.03] Fix racy batching on the dispatcher.#2695
Merged
dperny merged 1 commit intoJul 9, 2018
Merged
Conversation
Signed-off-by: Ying Li <ying.li@docker.com> (cherry picked from commit 317ad86) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
Codecov Report
@@ Coverage Diff @@
## bump_v18.03 #2695 +/- ##
===============================================
+ Coverage 61.6% 61.63% +0.02%
===============================================
Files 134 134
Lines 21795 21799 +4
===============================================
+ Hits 13426 13435 +9
- Misses 6929 6933 +4
+ Partials 1440 1431 -9 |
cyli
approved these changes
Jul 9, 2018
Contributor
cyli
left a comment
cyli
left a comment
There was a problem hiding this comment.
LGTM - I believe this is not critical - I don't think this should cause any issues aside from the batch running slightly more? But it's more correct. :)
Collaborator
|
Yeah, there's no harm at all in including this, it can only help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #2676 for 18.03
cherry-pick was clean