[18.03] address unassigned task leak when service is removed#2709
Merged
Conversation
Signed-off-by: Dani Louca <dani.louca@docker.com> Add a comment describing the function and adjust the log message Signed-off-by: Dani Louca <dani.louca@docker.com> Fixing existing unit tests Signed-off-by: Dani Louca <dani.louca@docker.com> Adding a test case to verify the leak fix Signed-off-by: Dani Louca <dani.louca@docker.com> simplifying the test Signed-off-by: Dani Louca <dani.louca@docker.com> comment Signed-off-by: Dani Louca <dani.louca@docker.com> (cherry picked from commit 9d977ce) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## bump_v18.03 #2709 +/- ##
===============================================
- Coverage 61.82% 61.47% -0.36%
===============================================
Files 134 134
Lines 21820 21827 +7
===============================================
- Hits 13491 13418 -73
- Misses 6888 6973 +85
+ Partials 1441 1436 -5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #2706 for the bump_v18.03 branch;
cherry-pick was clean; no conflicts