Revert "[manager/scheduler] Ignore unassigned tasks with desired state beyond running." [WIP]#2710
Closed
anshulpundir wants to merge 1 commit into
Closed
Revert "[manager/scheduler] Ignore unassigned tasks with desired state beyond running." [WIP]#2710anshulpundir wants to merge 1 commit into
anshulpundir wants to merge 1 commit into
Conversation
|
Please sign your commits following these rules: $ git clone -b "rev" git@github.com:anshulpundir/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
…e beyond running." This reverts commit e3fcf6d. Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2710 +/- ##
==========================================
- Coverage 61.89% 61.79% -0.11%
==========================================
Files 134 134
Lines 21771 21769 -2
==========================================
- Hits 13476 13452 -24
- Misses 6836 6864 +28
+ Partials 1459 1453 -6 |
Member
|
can we / should we write an (e2e) test based on |
Contributor
Author
I am going to try to add a unit-test that verifies the expected scheduler behavior. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e3fcf6d.(#2574)
This is likely the root cause for #2705