[Backport 17.06] allocator: Retry failed allocations immediately upon a deallocation#2711
Merged
Merged
Conversation
Member
|
I see this was already cherry-picked in #2642 - was that reverted? |
Contributor
Author
17.06 was reset for the EE16 release. |
Member
Ah, right; I thought we marked all those PR's (or left a comment); do you have an overview of the ones that are no longer in there? We should mark them (and check the release-tracking status for those) |
|
@anshulpundir seeing failure with 92833fd: |
Contributor
Author
|
this should help #2715 @andrewhsu |
We retry failed allocations every 5 minutes. If something else gets deallocated, we should trigger the retry immediately in case the allocations were failing due to IP exhaustion, and the deallocation freed up an IP. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com> (cherry picked from commit e913523) Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Codecov Report
@@ Coverage Diff @@
## bump_v17.06 #2711 +/- ##
===============================================
- Coverage 65.23% 61.49% -3.74%
===============================================
Files 59 121 +62
Lines 8816 20215 +11399
===============================================
+ Hits 5751 12431 +6680
- Misses 2470 6424 +3954
- Partials 595 1360 +765 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick #2235.
git cherry-pick -s -x e913523
Cherry-pick was clean.
We retry failed allocations every 5 minutes. If something else gets
deallocated, we should trigger the retry immediately in case the
allocations were failing due to IP exhaustion, and the deallocation
freed up an IP.
Signed-off-by: Aaron Lehmann aaron.lehmann@docker.com
(cherry picked from commit e913523)
Signed-off-by: Anshul Pundir anshul.pundir@docker.com