[manager/dispatcher] Fix deadlock in dispatcher shutdown#2742
Closed
anshulpundir wants to merge 1 commit into
Closed
[manager/dispatcher] Fix deadlock in dispatcher shutdown#2742anshulpundir wants to merge 1 commit into
anshulpundir wants to merge 1 commit into
Conversation
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2742 +/- ##
==========================================
- Coverage 61.77% 61.75% -0.02%
==========================================
Files 134 134
Lines 21888 21888
==========================================
- Hits 13522 13518 -4
+ Misses 6903 6900 -3
- Partials 1463 1470 +7 |
Collaborator
|
I was working on a test for this deadlock case, but it turns out that it's very non-trivial to elicit, and I don't think a test is possible. Here is my branch. I added a better explanation of some of the moving parts to the comments, and the commit message better explains what the cause of this deadlock is: |
Contributor
Author
|
addressed by #2744 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for https://github.com/docker/escalation/issues/698