Adding a hack/debug script#2766
Merged
wk8 merged 1 commit intomoby:masterfrom Nov 2, 2018
Merged
Conversation
wk8
force-pushed
the
wk8/debugging
branch
3 times, most recently
from
0c656f3 to
966db27
Compare
Codecov Report
@@ Coverage Diff @@
## master #2766 +/- ##
=========================================
- Coverage 61.96% 61.87% -0.1%
=========================================
Files 137 134 -3
Lines 22050 21876 -174
=========================================
- Hits 13664 13536 -128
+ Misses 6911 6883 -28
+ Partials 1475 1457 -18 |
wk8
force-pushed
the
wk8/debugging
branch
4 times, most recently
from
385739c to
baab982
Compare
Collaborator
|
I don't use Delve, so I can't comment on the usefulness, but it LGTM. |
anshulpundir
approved these changes
Oct 30, 2018
wk8
force-pushed
the
wk8/debugging
branch
3 times, most recently
from
26e0b93 to
20d8cf1
Compare
That's basically just a light wrapper around delve, to make it nicer to use (stops it after the session is done, and doesn't ignore interrupts like the vanilla version does). Also amending the containerized Makefile to add the right run options when using delve. That's controlled by the `DOCKER_SWARMKIT_USE_DELVE` env variable; it's also possible to override the port delve uses via the `DOCKER_SWARMKIT_DELVE_PORT` env variable. Signed-off-by: Jean Rouge <jer329@cornell.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's basically just a light wrapper around delve, to make it nicer to use
(stops it after the session is done, and doesn't ignore interrupts like
the vanilla version does).
Also amending the containerized Makefile to add the right run options
when using delve. That's controlled by the
DOCKER_SWARMKIT_USE_DELVEenv variable; it's also possible to override the port delve uses
via the
DOCKER_SWARMKIT_DELVE_PORTenv variable.