Skip to content

Run coverage tests once#2807

Open
dperny wants to merge 1 commit into
moby:masterfrom
dperny:run-coverage-once
Open

Run coverage tests once#2807
dperny wants to merge 1 commit into
moby:masterfrom
dperny:run-coverage-once

Conversation

@dperny
Copy link
Copy Markdown
Collaborator

@dperny dperny commented Jan 16, 2019

For some weird reason, make coverage runs the exact same command twice in a row. I can't find any reason why this would be needed. Removes the duplicate line, so tests only run once.

Should result in a 2x speedup of CI jobs lol

/cc @kolyshkin, who was the last person to touch this line when he removed the -i flag from the first of the two lines.

For some weird reason, make coverage runs the exact same command twice
in a row. I can't find any reason why this would be needed. Removes the
duplicate line, so tests only run once.

Should result in a 2x speedup of CI jobs lol

Signed-off-by: Drew Erny <drew.erny@docker.com>
@kolyshkin
Copy link
Copy Markdown
Contributor

the "double" line was added by commit 8ebe435 (PR #215). I believe since that time golang changed to not make any sense to -i (and using more proper/correct build cache) so that change can be reverted.

IOW, LGTM

@kolyshkin
Copy link
Copy Markdown
Contributor

for the reference, my commit removing -i with a description why is cb50952 (PR #2751). Now I see I should've removed the now-dup line (which is what this PR does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants