Add validation to CredentialSpec configs#2817
Merged
dperny merged 1 commit intomoby:masterfrom Mar 20, 2019
Merged
Conversation
Adds validation assuring that if a service uses a Config as a CredentialSpec, then the Config is included in the ConfigRefs with a RuntimeTarget. Signed-off-by: Drew Erny <drew.erny@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2817 +/- ##
==========================================
+ Coverage 61.95% 62.02% +0.06%
==========================================
Files 137 137
Lines 22107 22123 +16
==========================================
+ Hits 13696 13721 +25
+ Misses 6938 6930 -8
+ Partials 1473 1472 -1 |
This was referenced Mar 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Adds validation assuring that if a service uses a Config as a CredentialSpec, then the Config is included in the ConfigRefs with a RuntimeTarget.
- How to test it
Includes a test case, which I verified fails before this change and passes after.