[18.09 backport] Fix make check#2829
Merged
dperny merged 1 commit intomoby:bump_v18.09from Feb 12, 2019
Merged
Conversation
gometalinter dropped support for gosimple, which is deprecated anyway and has been subsumed by staticcheck. This commit removes gosimple from our list of enabled linters (as it's no longer valid). It does not enable staticcheck, because staticcheck throws too many errors. Signed-off-by: Drew Erny <drew.erny@docker.com> (cherry picked from commit 3bfc201) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @dperny @anshulpundir PTAL; this fixes CI on the 18.09 branch |
This was referenced Feb 11, 2019
Codecov Report
@@ Coverage Diff @@
## bump_v18.09 #2829 +/- ##
===============================================
- Coverage 61.79% 61.71% -0.09%
===============================================
Files 134 134
Lines 21868 21868
===============================================
- Hits 13513 13495 -18
- Misses 6902 6919 +17
- Partials 1453 1454 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #2811 for 18.09. cherry-pick was clean; no conflicts
gometalinter dropped support for gosimple, which is deprecated anyway
and has been subsumed by staticcheck. This commit removes gosimple from
our list of enabled linters (as it's no longer valid). It does not
enable staticcheck, because staticcheck throws too many errors.