Skip to content

[17.06 backport] Fix changing host target port failed#2864

Merged
dperny merged 1 commit into
moby:bump_v17.06from
dani-docker:1695_17.06
May 30, 2019
Merged

[17.06 backport] Fix changing host target port failed#2864
dperny merged 1 commit into
moby:bump_v17.06from
dani-docker:1695_17.06

Conversation

@dani-docker
Copy link
Copy Markdown
Contributor

CC: @dperny @thaJeztah backport for bump_17.06

Fixes a bug where if a service has the same number of host-mode
published ports with PublishedPort 0, changes to the spec would not
reflect in the service object.

Signed-off-by: Drew Erny drew.erny@docker.com
(cherry picked from commit 1602055)

- What I did

- How I did it

- How to test it

- Description for the changelog

Fixes a bug where if a service has the same number of host-mode
published ports with PublishedPort 0, changes to the spec would not
reflect in the service object.

Signed-off-by: Drew Erny <drew.erny@docker.com>
(cherry picked from commit 1602055)
@thaJeztah
Copy link
Copy Markdown
Member

backport of #2376

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dperny dperny merged commit b817f45 into moby:bump_v17.06 May 30, 2019
@thaJeztah thaJeztah changed the title Fix changing host target port failed [17.06 backport] Fix changing host target port failed May 31, 2019
@thaJeztah
Copy link
Copy Markdown
Member

@dani-docker can you open a vendor bump PR as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants