Improve information if IsStateDirty() fails#2909
Merged
Merged
Conversation
Before:
panic: unexpected field type in StoreSnapshot
After:
panic: unexpected field type in StoreSnapshot: XXX_NoUnkeyedLiteral struct
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @dani-docker @dperny PTAL |
Codecov Report
@@ Coverage Diff @@
## master #2909 +/- ##
==========================================
- Coverage 61.62% 61.48% -0.15%
==========================================
Files 139 139
Lines 22615 22615
==========================================
- Hits 13936 13904 -32
- Misses 7194 7231 +37
+ Partials 1485 1480 -5 |
Contributor
|
yes please! |
Member
Author
|
@dperny PTAL 🤗 |
Member
Author
|
@dperny @tonistiigi @crazy-max PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was a commit that was left over in #2837, and thought it could still be useful when debugging problems.
Before:
After: