Skip to content

manager/state/raft/storage: fix TestCreateOpenInvalidDirFails #3087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Nov 19, 2022
Merged

manager/state/raft/storage: fix TestCreateOpenInvalidDirFails #3087

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 10 additions & 11 deletions manager/state/raft/storage/walwrap_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,19 +196,18 @@ func TestSaveEncryptionFails(t *testing.T) {
require.Empty(t, ents)
}

// If the underlying WAL returns an error when opening or creating, the error
// is propagated up.
func TestCreateOpenInvalidDirFails(t *testing.T) {
// If the underlying WAL returns an error when opening, the error is
// propagated up.
func TestOpenInvalidDirFails(t *testing.T) {
c := NewWALFactory(encryption.NoopCrypter, encryption.NoopCrypter)

_, err := c.Create("/not/existing/directory", []byte("metadata"))
require.Error(t, err)

tempDir, err := os.MkdirTemp("", "test-migrate")
require.NoError(t, err)
defer os.RemoveAll(tempDir)

_, err = c.Open(tempDir, walpb.Snapshot{}) // invalid because no WAL file
tempDir := t.TempDir()
// using a subdirectory, as some of the code uses "filepath.Dir()"
// and we want to be sure we scope everything to inside the tempDir
// we created.
emptyDir := filepath.Join(tempDir, "empty_dir")
require.NoError(t, os.Mkdir(emptyDir, 0o700))
_, err := c.Open(emptyDir, walpb.Snapshot{}) // invalid because no WAL file
require.Error(t, err)
}

Expand Down