api: add timestamp to task status message#320
Merged
Conversation
stevvooe
force-pushed
the
taskstatus-timestamp
branch
3 times, most recently
from
9a9a5ad to
be31f27
Compare
Current coverage is
|
This was referenced Apr 14, 2016
Member
|
LGTM - needs rebase |
stevvooe
force-pushed
the
taskstatus-timestamp
branch
from
be31f27 to
8776311
Compare
Collaborator
There was a problem hiding this comment.
Where does this get set?
Contributor
Author
There was a problem hiding this comment.
Collaborator
There was a problem hiding this comment.
status has the type *api.TaskStatus, not taskStatusReport.
Adds the timestamp type to TaskStatus. This can open up some interesting behavior in the scheduler. For now, we let the agent set it, which may not be ideal. Note that we've had to do some nasty protobuf wrangling. External types still aren't well supported. We'll be able to remove all of this once gogoprotobuf supports timestamp. Signed-off-by: Stephen J Day <stephen.day@docker.com>
stevvooe
force-pushed
the
taskstatus-timestamp
branch
from
8776311 to
8d93e6a
Compare
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.