ci: add unparam linter #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
reviewed
Sep 26, 2024
1. Drop the last argument of tMount as it's always "". 2. Drop the error return of tMount, instead use t.Fatal. 3. Do the same for prepare. Fix the doc accordingly. 4. Add tCreateFile helper. 5. Change MkdirTemp to Mkdir since we have a new empty directory. 6. Inline some t.TempDir() calls. 7. Sprinkle t.Helper(). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Also: - sort the list of linters; - remove capability/.golangci.yml as it is now identical to the main one. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Collaborator
Author
|
Fixed review comments; PTAL @thaJeztah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.