[MODCLUSTER-758] improve proxy_cluster_post_request locking #609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can one of the admins verify this patch? If it is not dangerous to our systems, juts tell me to "run_tests". ( without the underscore and quotes 😃 ) |
Member
|
@jfclere Please review. Also, this will probably need a forward-port PR to 2.x. |
jfclere
approved these changes
Jul 7, 2022
Member
jfclere
left a comment
jfclere
left a comment
There was a problem hiding this comment.
The same code is in https://github.com/modcluster/mod_proxy_cluster/blob/main/native/mod_proxy_cluster/mod_proxy_cluster.c same patch applies there too
jfclere
requested changes
Jul 27, 2022
| return HTTP_INTERNAL_SERVER_ERROR; | ||
| } | ||
|
|
||
| int i; |
Member
There was a problem hiding this comment.
the int i; needs to be before the if()
Member
|
Upstream PR modcluster/mod_proxy_cluster#43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MODCLUSTER-758