Skip to content

MODCLUSTER-797 In Tomcat 8.5 the LifecycleListener does not pass an a… #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rhusar merged 1 commit into from
Aug 10, 2023
Merged

MODCLUSTER-797 In Tomcat 8.5 the LifecycleListener does not pass an a… #723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...at-8.5/src/main/java/org/jboss/modcluster/container/tomcat/TomcatEventHandlerAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.apache.catalina.Lifecycle;
import org.apache.catalina.LifecycleEvent;
import org.apache.catalina.LifecycleListener;
import org.apache.catalina.LifecycleState;
import org.apache.catalina.Server;
import org.apache.catalina.Service;
import org.jboss.modcluster.container.ContainerEventHandler;
Expand Down Expand Up @@ -136,6 +137,12 @@ public void containerEvent(ContainerEvent event) {
((Container) child).addPropertyChangeListener(this);

// n.b. MODCLUSTER-790 do not ContainerEventHandler#add(..) the context here - wait for actual start(..)

// In Tomcat 8.5 the LifecycleListener does not pass an after_start event and thus this is the only event
// obtained during 'autoDeploy', so we need to start the context from here, which is already started:
if (this.start.get() && (child instanceof Context) && (LifecycleState.STARTED == ((Context) child).getState())) {
this.eventHandler.start(new TomcatContext(registry, (Context) child));
}
} else if (container instanceof Engine) {
// Deploying a host
container.addContainerListener(this);
Expand Down