MODCLUSTER-807 Change the mod_cluster license to ASL 2.0 #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajik
requested changes
Dec 7, 2023
Member
jajik
left a comment
jajik
left a comment
There was a problem hiding this comment.
Other than the http instead of httpS it looks correct.
I left there some comments about inconsistent blank spaces after comments, but that's not an issue.
container/spi/src/main/java/org/jboss/modcluster/container/Connector.java
Outdated
Show resolved
Hide resolved
container/tomcat-8.5/src/main/java/org/jboss/modcluster/container/tomcat/mbeans-descriptors.xml
Outdated
Show resolved
Hide resolved
container/tomcat-9.0/src/main/java/org/jboss/modcluster/container/tomcat/mbeans-descriptors.xml
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/modcluster/config/ProxyConfiguration.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/AbstractConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/AdvertiseConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/BalancerConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/ConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/jboss/modcluster/config/builder/Creator.java
Outdated
Show resolved
Hide resolved
rhusar
force-pushed
the
MODCLUSTER-807
branch
from
90c3e07 to
7bb6473
Compare
jajik
requested changes
Dec 7, 2023
rhusar
force-pushed
the
MODCLUSTER-807
branch
from
7bb6473 to
ee40f1d
Compare
Member
Author
|
Thanks for the 2nd pair of eyes review @jajik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
https://issues.redhat.com/browse/MODCLUSTER-807